Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix paymaster tests in cicd #151

Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore: fix paymaster tests in cicd #151

merged 2 commits into from
Dec 13, 2024

Conversation

joepegler
Copy link
Collaborator

@joepegler joepegler commented Dec 13, 2024

PR-Codex overview

This PR focuses on updating configuration settings in the GitHub Actions workflow, refining the test files for the BicoPaymasterClient, and improving the README documentation for installation and testing instructions.

Detailed summary

  • Updated .github/workflows/unit-tests.yml to replace BUNDLER_URL and add PAYMASTER_URL from secrets.
  • Simplified smartSessions.decorators.test.ts by removing unnecessary moduleData.
  • Removed unused BicoBundlerClient in createBicoPaymasterClient.test.ts.
  • Revised README installation steps by removing the dependency installation command and enhancing usage instructions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@joepegler joepegler requested a review from VGabriel45 December 13, 2024 20:31
Copy link

size-limit report 📦

Path Size
core (esm) 14.31 KB (0%)
core (cjs) 20.21 KB (0%)
bundler (tree-shaking) 543 B (0%)
paymaster (tree-shaking) 123 B (0%)

@joepegler joepegler merged commit 0c7940d into develop Dec 13, 2024
5 checks passed
@joepegler joepegler deleted the fix/paymaster_tests branch December 13, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant