Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/excess override on is valid signature unsafe #193

Closed

Conversation

filmakarov
Copy link
Collaborator

Summary

AS per Chirag request

@livingrockrises
Copy link
Contributor

umm looks like all of these functions come from corresponding interfaces and not base contracts we are deriving from. and all interface functions are implicitly virtual. so override is merely clarifying and it's fine

@livingrockrises
Copy link
Contributor

Using override explicitly indicates that you are implementing a function from an interface or a base contract. While it is not strictly necessary, it can make the code more readable, especially in larger codebases where it might not be immediately clear that a particular function is part of an interface

:/ my bad I didn't see they are from interfaces.

@livingrockrises
Copy link
Contributor

I actually copied AccountRecoveryModule from develop branch to v2-deployments-with-config branch but now I realise interfaces in later branch don't have these methods and hence my override didn't work which led me into this thinking and initiate conversation / suggestion with you.

(My opinion close PR with this comment)

@filmakarov filmakarov closed this Jan 23, 2024
@filmakarov filmakarov deleted the fix/excess-override-on-isValidSignature-Unsafe branch January 23, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants