Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepack contracts and gen dist for publish #143

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

livingrockrises
Copy link
Contributor

@livingrockrises livingrockrises commented Oct 3, 2023

Summary

Fixes export of typechain types so it can be easily used in the sdk and other downstreams
update package versions and rearrange some dependencies.

Please suggest package name and version to be published from main org. Thank you

Related Issue: # (issue number)

Change Type

  • Bug Fix
  • Refactor
  • New Feature
  • Breaking Change
  • Documentation Update
  • Performance Improvement
  • Other

Checklist

  • My code follows this project's style guidelines
  • I've reviewed my own code
  • I've added comments for any hard-to-understand areas
  • I've updated the documentation if necessary
  • My changes generate no new warnings
  • I've added tests that prove my fix is effective or my feature works
  • All unit tests pass locally with my changes
  • Any dependent changes have been merged and published

Additional Information

Branch Naming

package.json Outdated
"postinstall": "husky install",
"prepack": "pinst --disable",
"postpack": "pinst --enable",
"_postinstall": "husky install",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this prefixed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i noticed it's done by mistake. will update it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved. merging

@livingrockrises livingrockrises merged commit aca3977 into develop Oct 4, 2023
@livingrockrises livingrockrises deleted the prepack-contracts-and-gen-dist-for-publish branch October 4, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants