Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getCurrentLiquidity() bug fix #99

Open
wants to merge 3 commits into
base: master-legacy-hyphen
Choose a base branch
from
Open

getCurrentLiquidity() bug fix #99

wants to merge 3 commits into from

Conversation

divyaN73
Copy link
Contributor

…ithdrawFee functions

Description

  • SetCurrentLiquidity() method added in LiquidityProvider.sol & LiquidityPool.sol
  • WithdrawErc20GasFee() & WithdrawNativeGasFee() modified

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@divyaN73 divyaN73 changed the title SetCurrentLiquidity method added. DecreaseLiquidity method added in w… getCurrentLiquidity() bug fix Jan 11, 2023
ankurdubey521
ankurdubey521 requested changes Jan 12, 2023
View reviewed changes
contracts/hyphen/LiquidityPool.sol Outdated Show resolved Hide resolved
contracts/hyphen/LiquidityProviders.sol Show resolved Hide resolved
ankurdubey521
ankurdubey521 requested changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@ankurdubey521 ankurdubey521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, but we need to add test cases to validate our fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankurdubey521 ankurdubey521 ankurdubey521 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divyaN73 @ankurdubey521