migrate metrics path to /metrics

This resolves grafana#3597
bck01215 · Sep 25, 2024 · 79ab355 · 79ab355
1 parent 0ef6bb7
commit 79ab355
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -71,7 +71,7 @@ We prepared multiple environments:
 
    scrape_configs:
      - job_name: prometheus
-       metrics_path: /metrics/
+       metrics_path: /metrics
        authorization:
          credentials: my_random_prometheus_secret
        static_configs:

diff --git a/dev/helm-local.yml b/dev/helm-local.yml
@@ -152,7 +152,7 @@ prometheus:
       scrape_interval: 10s
   extraScrapeConfigs: |
     - job_name: 'oncall-exporter'
-      metrics_path: /metrics/
+      metrics_path: /metrics
       static_configs:
         - targets:
           - oncall-dev-engine.default.svc.cluster.local:8080
diff --git a/engine/apps/metrics_exporter/urls.py b/engine/apps/metrics_exporter/urls.py
@@ -3,5 +3,5 @@
 from .views import MetricsExporterView
 
 urlpatterns = [
-    path("", MetricsExporterView.as_view(), name="metrics-exporter"),
+    path(r"^/?$", MetricsExporterView.as_view(), name="metrics-exporter"),
 ]
diff --git a/engine/engine/urls.py b/engine/engine/urls.py
@@ -48,7 +48,7 @@
 
 if settings.FEATURE_PROMETHEUS_EXPORTER_ENABLED:
     urlpatterns += [
-        path("metrics/", include("apps.metrics_exporter.urls")),
+        path("metrics", include("apps.metrics_exporter.urls")),
     ]
 
 if settings.FEATURE_TELEGRAM_INTEGRATION_ENABLED:

diff --git a/helm/oncall/values.yaml b/helm/oncall/values.yaml
@@ -722,7 +722,7 @@ prometheus:
   enabled: false
   # extraScrapeConfigs: |
   #   - job_name: 'oncall-exporter'
-  #     metrics_path: /metrics/
+  #     metrics_path: /metrics
   #     static_configs:
   #       - targets:
   #         - oncall-dev-engine.default.svc.cluster.local:8080