Fix options infocation #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove incorrect parameter from the action handler function
|
Here's an example run, with the change, and with some additional debug I added:
|
|
Thanks for your prompt attention! 🥇 |
|
Thank you for fixing this issue. On May 12, 2024, at 3:30 PM, SemiConscious ***@***.***> wrote:
Thanks for your prompt attention! 🥇
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There.
Thanks for this incredibly useful action! But I believe I found a flaw: I was unable to get the
--releaseswitch to work.After checking the commander documentation and after experimenting in practice, it seems that the
--releaseand--silentoptions are effectively ignored, due to the signature of the commander action handler being incorrect. I have removed the firstcmdparameter, which I think should only be there if there was an actual argument expected. With no argument, the first parameter in the action handler should beoptions. This fixes the observed issue of not being able to create non-draft releases.I have had a look at your tests and I can't see any that would fail due to
--releaseor--silentnot being handled, so I think this may have been an issue for a while.Hope this helps.