Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/batch forest client data refresh #500

Merged
merged 18 commits into from
Dec 22, 2023

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Dec 20, 2023

#248...

  • Add CLIENT_API_TOKEN environment variable from OpenShift secret.
  • Rename previous batch to '${NAME}-${ZONE}-work-flow-state-change-batch'.
  • Add new CronJob for 'fc-client-data-refresh-batch'.
  • Adjust name of the package.json batch run scripts.
  • Install @nestjs/axios for use on NestJs Http.
  • Minor refactor on constant.
  • Add CLIENT API service configuration.
  • Create new client-app-integration.module.ts and service for integration of ClIENT API.
  • Configure ClientAppIntegrationModule with HttpModule instance using Axios.
  • Add fetching logic with client-app-integration.service.ts for endpoint "findAllNonIndividuals".
  • Use ClientAppIntegrationModule in forest-client.module.ts
  • Adjust forest-client.service.ts and its controller away from ReadOnlyService to regular DataService to be able to persist.
  • Implement fetch and refresh logic at forest-client service.
  • Add second runBatch lgoc with -argv for new data refreshing job function.

Thanks for the PR!

Any successful deployments (not always required) will be available below.

Once merged, code will be promoted and handed off to following workflow run.

@ianliuwk1019 ianliuwk1019 requested a review from basilv December 21, 2023 00:07
@ianliuwk1019
Copy link
Collaborator Author

TODO: just notice, will need to add TEST/PROD environment: CLIENT_API_BASE_URL. Right now it is using default value.

@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review December 22, 2023 17:45
@ianliuwk1019
Copy link
Collaborator Author

TODO: just notice, will need to add TEST/PROD environment: CLIENT_API_BASE_URL. Right now it is using default value.

This has been added.

@ianliuwk1019 ianliuwk1019 requested a review from basilv December 22, 2023 22:59
@ianliuwk1019 ianliuwk1019 merged commit 3060baa into main Dec 22, 2023
14 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/batch-forestClient-data-refresh branch December 22, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants