Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wfnews 2422 fix #2128

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Wfnews 2422 fix #2128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d6c295
try adding meta tag in index.html
yzlucas Nov 5, 2024
b9b28ab
try adding meta tag in index.html
yzlucas Nov 5, 2024
cef27ad
Merge branch 'bcgov:branch-2.4.0' into wfnews-2422-fix
yzlucas Nov 6, 2024
a85bebc
get rid of file upload in capacitor share
yzlucas Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/wfnews-war/src/main/angular/src/app/app.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ export class AppComponent implements OnDestroy, OnInit, AfterViewInit {
this.metaService.updateTag({ property: 'og:title', content: 'BC Wildfire Service' });
this.metaService.updateTag({ property: 'og:image', content: imageUrl });
this.metaService.updateTag({ property: 'og:site_name', content: 'BC Wildfire Service' });
this.metaService.updateTag({ name: 'description', content: `BC Wildfire Service App` });
this.metaService.updateTag({ name: 'twitter:card', content: 'summary_large_image' });
this.metaService.updateTag({ name: 'twitter:site', content: '@BCGovFireInfo' });
}
Expand Down
2 changes: 2 additions & 0 deletions ...s/full-details/area-restrictions-full-details/area-restrictions-full-details.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ export class AreaRestrictionsFullDetailsComponent implements OnInit {
});
this.initMap();
this.metaService.updateTag({ property: 'og:title', content: this.restrictionData?.name });
this.metaService.updateTag({ name: 'description', content: this.restrictionData?.name });

}

async initMap() {
Expand Down
1 change: 1 addition & 0 deletions .../angular/src/app/components/full-details/bans-full-details/bans-full-details.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export class BansFullDetailsComponent implements OnInit {
});
this.initMap();
this.metaService.updateTag({ property: 'og:title', content: `Fire Ban on ${this.banData.description} Open Fires`});
this.metaService.updateTag({ name: 'description', content: `Fire Ban on ${this.banData.description} Open Fires` });
}

async initMap() {
Expand Down
1 change: 1 addition & 0 deletions ...omponents/full-details/danger-rating-full-details/danger-rating-full-details.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export class DangerRatingFullDetailsComponent implements OnInit {
async ngOnInit(): Promise<void> {
this.initMap();
this.metaService.updateTag({ property: 'og:title', content: `${this.rating} Danger Rating`});
this.metaService.updateTag({ name: 'description', content: `${this.rating} Danger Rating` });
}

dangerDescription() {
Expand Down
2 changes: 2 additions & 0 deletions .../app/components/full-details/evac-alert-full-details/evac-alert-full-details.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ export class EvacAlertFullDetailsComponent implements OnInit {
});
this.initMap();
this.metaService.updateTag({ property: 'og:title', content: `Evacuation Alert for ${this.evacData.name}`});
this.metaService.updateTag({ name: 'description', content: `Evacuation Alert for ${this.evacData.name}` });

}

async initMap() {
Expand Down
2 changes: 2 additions & 0 deletions ...p/components/public-incident-page/incident-info-header/incident-header-panel.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,8 @@ export class IncidentHeaderPanelComponent implements AfterViewInit, OnInit {
}
}
this.metaService.updateTag({ property: 'og:title', content: `${this.incident?.incidentName}`});
this.metaService.updateTag({ name: 'description', content: `${this.incident?.incidentName}` });

}

ngAfterViewInit(): void {
Expand Down
1 change: 0 additions & 1 deletion client/wfnews-war/src/main/angular/src/app/services/common-utility.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,6 @@ export class CommonUtilityService {
text: 'Share the incident update',
url: currentUrl,
dialogTitle: 'Share Wildfire News Link',
files: [imageUrl]
}).then(() => {
console.log('Sharing successful');
}).catch(err => {
Expand Down
3 changes: 1 addition & 2 deletions client/wfnews-war/src/main/angular/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta charset="utf-8">
<meta name="description" content="BC Wildfire Service App">
<title>BC Wildfire Service</title>

<meta property="og:title" content="BC Wildfire Service">
<meta property="og:image" content="assets/images/share-wildfire.png">
<meta property="og:site_name" content="BC Wildfire Servic">
<meta property="og:site_name" content="BC Wildfire Service">
<meta name="twitter:card" content="summary_large_image">
<meta name="twitter:site" content="@BCGovFireInfo'">

Expand Down
Loading