Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: work on vertical notifications #1337

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Conversation

jleach
Copy link
Member

@jleach jleach commented Aug 9, 2023

This PR contains the following notable changes:

  • aligns notifications in a column rather than a row;
  • uses a FlatList Header and Footer rather than custom notification.

Depends on openwallet-foundation/bifold-wallet#922

@jleach jleach added the do not merge This PR is on hold. label Aug 10, 2023
@jleach jleach self-assigned this Aug 10, 2023
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach marked this pull request as ready for review August 10, 2023 21:56
Signed-off-by: Jason C. Leach <[email protected]>
@jleach jleach removed the do not merge This PR is on hold. label Aug 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bryce-mcmath bryce-mcmath merged commit 07970ec into main Aug 11, 2023
9 checks passed
@bryce-mcmath bryce-mcmath deleted the feat/vert-home-notif branch August 11, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants