Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edits to collector field validation and relevant files #23

Merged
merged 2 commits into from
Oct 30, 2024
Merged

edits to collector field validation and relevant files #23

merged 2 commits into from
Oct 30, 2024

Conversation

ozdemirozcelik
Copy link
Contributor

This PR does the following:

  • Changes version number to 3.2.0 in gdx_analytics_drupal_snowplow.info.yml
  • Edits version reference in README.md
  • Adds additional validation to collector field in src/Form/SettingsForm.php to ensure it is a valid domain

Testing:

  • Install the module as you would normally install for Drupal
  • Navigate to the module settings and attempt to save different combinations in the collector environment field

@vikasvermacertain vikasvermacertain self-assigned this Oct 30, 2024
@ozdemirozcelik ozdemirozcelik merged commit 53c3ba5 into main Oct 30, 2024
2 checks passed
@ozdemirozcelik ozdemirozcelik deleted the GDXDSD7200-add-collector-field-validation branch October 30, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikasvermacertain vikasvermacertain vikasvermacertain approved these changes

@cnburnett cnburnett Awaiting requested review from cnburnett

Assignees

@vikasvermacertain vikasvermacertain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ozdemirozcelik @vikasvermacertain