Merge pull request #1225 from bcgov/fix/remove-rules

EDX-1994, EDX-1995, EDX-1996 - removes unnecessary/redundant rules
bcgov · Nov 27, 2023 · 1b8adf7 · 1b8adf7
2 parents e4ed5d0 + 06cfd77
commit 1b8adf7
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 25 deletions.
diff --git a/backend/src/components/sdc.js b/backend/src/components/sdc.js
@@ -277,7 +277,7 @@ function createSearchCriteria(searchParams = []) {
   let fundingWarningCategories = [
     {
       categoryCode: 'NOPROGFUNDINGHS',
-      validationErrors: ['PROGRAMCODEHSLANG', 'PROGRAMCODEHSIND', 'PROGRAMCODEHSCAREER', 'PROGRAMCODEHSSPED']
+      validationErrors: ['PROGRAMCODEHSLANG', 'PROGRAMCODEHSIND', 'PROGRAMCODEHSSPED']
     },
     {
       categoryCode: 'ZEROCOURSE',
@@ -299,17 +299,9 @@ function createSearchCriteria(searchParams = []) {
       categoryCode: 'NOFUNDSUPPORT',
       validationErrors: ['SUPPORTFACILITYNA', 'ADULTSUPPORTERR', 'CHANGEME']
     },
-    {
-      categoryCode: 'NOFUNDSPED',
-      validationErrors: ['SPEDOFFSHOREERR']
-    },
     {
       categoryCode: 'NOFUNDGRADADULT',
       validationErrors: ['CHANGEME']
-    },
-    {
-      categoryCode: 'NOCAREERPROGFUND',
-      validationErrors: ['CAREEROFFSHOREERR']
     }
   ];
 

diff --git a/frontend/src/components/sdcCollection/StepTwoValidateData.vue b/frontend/src/components/sdcCollection/StepTwoValidateData.vue
@@ -769,17 +769,9 @@ export default {
           category: 'No funding for Support Blocks',
           categoryCode: 'NOFUNDSUPPORT'
         },
-        {
-          category: 'No funding for Special Education',
-          categoryCode: 'NOFUNDSPED'
-        },
         {
           category: 'No funding for Graduated Adults',
           categoryCode: 'NOFUNDGRADADULT'
-        },
-        {
-          category: 'No career program funding',
-          categoryCode: 'NOCAREERPROGFUND'
         }
       ]
     };

diff --git a/frontend/src/components/sdcCollection/stepTwoValidateData/StepTwoViewDataIssues.vue b/frontend/src/components/sdcCollection/stepTwoValidateData/StepTwoViewDataIssues.vue
@@ -359,17 +359,9 @@ export default {
           category: 'No funding for Support Blocks',
           categoryCode: 'NOFUNDSUPPORT'
         },
-        {
-          category: 'No funding for Special Education',
-          categoryCode: 'NOFUNDSPED'
-        },
         {
           category: 'No funding for Graduated Adults',
           categoryCode: 'NOFUNDGRADADULT'
-        },
-        {
-          category: 'No career program funding',
-          categoryCode: 'NOCAREERPROGFUND'
         }
       ]
     };