Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make helm-projectile-ag provide a default search input like helm-proj… #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Chobbes
Copy link

@Chobbes Chobbes commented Oct 17, 2022

…ectile-grep.

When using helm-projectile-grep the search term will automatically be populated with the symbol at point, or the selected region. These changes make helm-projectile-ag do the same thing.


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines (Not sure this exists??)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@Chobbes
Copy link
Author

Chobbes commented Oct 20, 2022

Apparently there is already an option for this within helm-ag itself...

(setq helm-ag-insert-at-point 'symbol)

That said, I do wonder if it should follow helm-projectile-set-input-automatically. The documentation for helm-projectile-set-input-automatically does mention this:

Applies to ‘helm-projectile-grep’ and
‘helm-projectile-ack’ only. If the ‘helm-ag’ package is
installed, then automatic input behavior for ‘helm-projectile-ag’
can be customized using ‘helm-ag-insert-at-point’.

So maybe this has all been considered before... Still, it seems an odd default for helm-projectile-ag. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant