Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use com_google_protobuf in WORKSPACE #2432

Merged
merged 14 commits into from
Nov 21, 2024
Merged

fix: use com_google_protobuf in WORKSPACE #2432

merged 14 commits into from
Nov 21, 2024

Commits on Nov 21, 2024

  1. fix: flags on CI workspace setups

    @comius
    comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ff2d97d View commit details
    Browse the repository at this point in the history

  2. Skip integration tests on Windows workspace mode.

    @comius
    comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0d3ea78 View commit details
    Browse the repository at this point in the history

  3. fix: use com_google_protobuf in WORKSPACE 

    The only way to support both workspace and bzlmod mode, is to call
protobuf com_google_protobuf.

Upgrade rules_cc to 0.0.16 and rules_java to 8.3.1. Those are minimal
versions that are also calling protobuf again com_google_protobuf.
    @comius
    comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    dacd3e5 View commit details
    Browse the repository at this point in the history

  4. Set up rules_java in WORKSPACE

    @comius
    comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e520948 View commit details
    Browse the repository at this point in the history

  5. Match WORKSPACE protobuf version with bzlmod version

    @comius
    comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f41f51c View commit details
    Browse the repository at this point in the history

  6. Upgrade protobuf in internal setup

    @comius
    comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f5adc3a View commit details
    Browse the repository at this point in the history

  7. Upgrade bazel_skylib to 1.7.0, required by protobuf

    @comius
    comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0d9c3e5 View commit details
    Browse the repository at this point in the history

  8. Update changelog

    @rickeylev @comius
    rickeylev authored and comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1312ff9 View commit details
    Browse the repository at this point in the history

  9. Upgrade rules_cc to 0.1.0 in WORKSPACE

    @comius
    comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1e43ae6 View commit details
    Browse the repository at this point in the history

  10. Disable doc targets in workspace mode

    @comius
    comius committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ffb3798 View commit details
    Browse the repository at this point in the history

  11. fix changlog, add note about com_google_protobuf repo name

    @rickeylev
    rickeylev committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7771c0d View commit details
    Browse the repository at this point in the history

  12. Set docs as incompatible for workspace builds

    @rickeylev
    rickeylev committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f2cf35c View commit details
    Browse the repository at this point in the history

  13. remove disable_docs config from presubmit; target_compatible_with ski… 

    …ps docs instead now
    @rickeylev
    rickeylev committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9b63950 View commit details
    Browse the repository at this point in the history

  14. Merge remote-tracking branch 'upstream/main' into use-com_google_prot… 

    …obuf
    @rickeylev
    rickeylev committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    839c1c7 View commit details
    Browse the repository at this point in the history