Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gazelle_python.yaml will always be generated whether integrity matches or not. #2096

Closed
hunshcn opened this issue Jul 27, 2024 · 0 comments · Fixed by #2097
Closed

gazelle_python.yaml will always be generated whether integrity matches or not. #2096

hunshcn opened this issue Jul 27, 2024 · 0 comments · Fixed by #2097

Comments

@hunshcn
Copy link
Contributor

hunshcn commented Jul 27, 2024

🐞 bug report

Affected Rule

gazelle_python_manifest

Is this a regression?

Yes

Description

After I upgraded rules_python for a project, I found that the ci of the project failed frequently. I noticed that I was restricted by frequent requests for pypi(mirror). failed with gazelle_python_manifest.genrule. (Because I test with bazel test //...

But this is not expected, because there is integrity in my gazelle_python.yaml.

#1666 make a change that a new genrule with diff_test.

this genrule and update target are not manual, so it will be built by running bazel test //....

This obviously goes against the purpose of integrity (we don't want to regenerate gazelle_python.yaml for the same requirements).

🔬 Minimal Reproduction

🔥 Exception or Error

Any repo

🌍 Your Environment

Operating System:

linux/macos

Output of bazel version:

7.2.1

Rules_python version:

0.34.0

Anything else relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant