Skip to content

Commit

Permalink
fix(gazelle): make gazelle_python_manifest.genrule manual (#2097)
Browse files Browse the repository at this point in the history
Fix #2096

---------

Co-authored-by: Ignas Anikevicius <[email protected]>
  • Loading branch information
hunshcn and aignas authored Aug 1, 2024
1 parent dbc6c04 commit 7064f6b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
10 changes: 6 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ A brief description of the categories of changes:
when the wheel is downloaded using `download_only` feature to aid debugging.
* (gazelle): Simplify and make gazelle_python.yaml have only top level package name.
It would work well in cases to reduce merge conflicts.
* (toolchains): Change some old toochain versions to use [20240726] release to
include dependency updates `3.8.19`, `3.9.19`, `3.10.14`, `3.11.9`
* (toolchains): Bump default toolchain versions to:
* `3.12 -> 3.12.4`

### Fixed
* (rules) Signals are properly received when using {obj}`--bootstrap_impl=script`
Expand All @@ -49,10 +53,8 @@ A brief description of the categories of changes:
* (pip) Correctly use the `sdist` downloaded by the bazel downloader when using
`experimental_index_url` feature. Fixes
[#2091](https://github.com/bazelbuild/rules_python/issues/2090).
* (toolchains): Change some old toochain versions to use [20240726] release to
include dependency updates `3.8.19`, `3.9.19`, `3.10.14`, `3.11.9`
* (toolchains): Bump default toolchain versions to:
* `3.12 -> 3.12.4`
* (gazelle) Make `gazelle_python_manifest.update` manual to avoid unnecessary
network behavior.

### Added
* (rules) `PYTHONSAFEPATH` is inherited from the calling environment to allow
Expand Down
4 changes: 3 additions & 1 deletion gazelle/manifest/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def gazelle_python_manifest(
modules_mapping,
manifest_generator_hash,
] + ([requirements] if requirements else []),
tags = ["manual"],
)

py_binary(
Expand All @@ -109,7 +110,8 @@ def gazelle_python_manifest(
generated_manifest,
manifest,
],
**kwargs
tags = kwargs.get("tags", []) + ["manual"],
**{k: v for k, v in kwargs.items() if k != "tags"}
)

if requirements:
Expand Down

0 comments on commit 7064f6b

Please sign in to comment.