Pass javac options to Kapt javacArguments so the javac_options warn='off' option works for annotation processors that print warnings #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheister
requested review from
ahumesky,
cgruber,
restingbull,
Bencodes and
nkoroste
as code owners
cheister
force-pushed
the
passJavacOptsToKapt
branch
from
237d0c4
to
3fdce47
Compare
cheister
force-pushed
the
passJavacOptsToKapt
branch
from
3fdce47
to
23b7d9d
Compare
…off' option works for annotation processors that print warnings
cheister
force-pushed
the
passJavacOptsToKapt
branch
from
23b7d9d
to
49d72a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our codebase we're using the MapStruct annotation processor which can print out a lot of warnings for unmapped target properties when the annotation processors are run.
Using javac_options with
warn = "off"does not silience these warnings and using javac_options with
warn = "error"does not cause errors for these warnings.The reason is because the javac options were not passed to the Kapt processor invocation. This PR passes the javac_options to the Kapt processor and adds the parameter "-Xlint:none" so the annotation processor warnings are silenced when using
warn = "off"