Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test platforms transition everywhere #2412

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Test platforms transition everywhere #2412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apple/internal/rule_factory.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ of the target will be used instead.

def _create_apple_rule(
*,
cfg = transition_support.apple_rule_transition,
cfg = transition_support.apple_platforms_rule_base_transition,
doc,
implementation,
is_executable = False,
Expand All @@ -109,8 +109,7 @@ def _create_apple_rule(

Args:
cfg: The rule transition to be applied directly on the generated rule. Optional. This will
be the Starlark Apple rule transition `transition_support.apple_rule_transition` by
default.
be the Starlark Apple rule transition by default.
doc: The documentation string for the rule itself.
implementation: The method to handle the implementation of the given rule. Optional. True
by default.
Expand Down
2 changes: 1 addition & 1 deletion apple/internal/testing/build_test_rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,5 +122,5 @@ number (for example, `"9.0"`).
doc = doc,
implementation = _apple_build_test_rule_impl,
test = True,
cfg = transition_support.apple_rule_transition,
cfg = transition_support.apple_platforms_rule_base_transition,
)