Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black screen when using disable_signing_resource_rules and launch storyboard #2072

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chatwyn
Copy link

@chatwyn chatwyn commented Aug 16, 2023

Hello maintainers,

I'm submitting this pull request to address an issue that occurs when my storyboard is set as the startup screen and I utilize signed acceleration. In this scenario, if I cold launch the application on the simulator a black screen issue arises. To mitigate this problem, I suggest extending the signing process to include the storyboard as well.

Steps to Reproduce:

Set the storyboard as the startup screen.
Utilize signed acceleration for the startup process.
Launch the application on the simulator.

Expected Behavior:

The application should launch properly without any black screen issues.

Actual Behavior

A black screen appears during the startup process on the simulator.

Proposed Solution:

To address this issue, I recommend extending the code signing process to include the storyboard. By signing both the main application and the storyboard, we can ensure consistent behavior during the startup process, preventing the occurrence of the black screen problem.

Best regards,
caowenbo

@brentleyjones brentleyjones changed the title fix Issue with Black Screen when Using Signed Acceleration Fix black screen when using disable_signing_resource_rules and launch storyboard Aug 16, 2023
@keith
Copy link
Member

keith commented Aug 16, 2023

interesting case! I tested this locally on our app where we use this as well and it didn't seem to fix the issue for me. does it reliably fix it for you? could it have something to do with just relaunching the same app instead? removing the resource rules fixes it for me but not this change

@keith
Copy link
Member

keith commented Aug 16, 2023

could it be that compiled storyboards actually have different extensions than this? Lyft.app/AppLaunchUIResources.bundle/Base.lproj/LaunchScreen.storyboardc/LaunchScreen.nib

@keith
Copy link
Member

keith commented Aug 16, 2023

seems like doing .*nib might be working in our case

@chatwyn
Copy link
Author

chatwyn commented Aug 17, 2023

Sure. when I add it in the resource rules, it can solve my problem.
And In MY *.app/_CodeSignatureCodeResources will show the nib name, such as

 <key>StartLogo.storyboardc/01J-lp-oVM-view-Ze5-6b-2t3.nib</key>
<data>
ZX9hKRVSyKfPkYmyQU8Qi+FMX22
</data>

@brentleyjones
Copy link
Collaborator

Does a *.storyboardc based key work? Might need to adjust to to apply to sub-files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants