Enable -dead_strip by default for opt builds #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
keith
force-pushed
the
ks/enable-dead_strip-by-default-for-opt-builds
branch
2 times, most recently
from
f329554
to
cb8bef0
Compare
thii
approved these changes
Aug 24, 2023
mattrobmattrob
approved these changes
Aug 24, 2023
keith
force-pushed
the
ks/enable-dead_strip-by-default-for-opt-builds
branch
from
cb8bef0
to
68f67b3
Compare
keith
force-pushed
the
ks/enable-dead_strip-by-default-for-opt-builds
branch
from
68f67b3
to
b99056c
Compare
This change makes `-dead_strip` always be enabled for `opt` builds, regardless of `--objc_enable_binary_stripping`. This should be the right default for everyone, if not we can look at adding a way to disable it. This also allows passing `--features=dead_strip` to enable `-dead_strip` in other configurations, which previously wasn't supported if you weren't using `opt`.
keith
force-pushed
the
ks/enable-dead_strip-by-default-for-opt-builds
branch
from
b99056c
to
f72129e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
-dead_stripalways be enabled foroptbuilds,regardless of
--objc_enable_binary_stripping. This should be the rightdefault for everyone, if not we can look at adding a way to disable it.
This also allows passing
--features=dead_stripto enable-dead_stripin other configurations, which previously wasn't supported if you
weren't using
opt.