Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pytest-black plug as its no longer maintained to keep CI green #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yctomwang
Copy link
Collaborator

@yctomwang yctomwang commented Feb 7, 2024

remove pytest-black plug as its no longer maintained, and casuing error with our CI for python version 3.8 and above, #87

Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@yctomwang yctomwang marked this pull request as ready for review February 7, 2024 01:02
@yctomwang yctomwang self-assigned this Feb 7, 2024
@yctomwang yctomwang requested review from bauerji and jkseppan February 7, 2024 01:03
@yctomwang yctomwang changed the title remove pytest-black plug as its no longer maintained remove pytest-black plug as its no longer maintained to keep CI green Feb 7, 2024
Copy link
Collaborator

@jkseppan jkseppan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that pytest-black seems to have been abandoned. Perhaps ruff with suitable formatting rules could be a replacement.

@yctomwang
Copy link
Collaborator Author

looks like i cannot merge from the UI as its pending for the build 3.7 and build 3.8, I think I might merge from command line

@yctomwang
Copy link
Collaborator Author

@bauerji Hi Jiri it looks like this PR is blocked because of the build 3.7 and build 3.8. Also seems like I cannot push to master because of some kind of branch protection. if you have some time, can you please review this and get it merged so CI is fixed. Thanks Thomas
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants