Make JsonSchemaAssertions check for JSON content-type #65
Conversation
Yes. I can forsee that an |
| @@ -55,6 +60,12 @@ public void execute(int statusCode, | |||
| } | |||
| } | |||
|
|
|||
| public JsonSchemaAssertions overrideContentType(ContentType contentType) { | |||
There was a problem hiding this comment.
Could you add JavaDocs to this public method, please? I think you can add the same JavaDocs as JsonResponseAsserions.
| * @param contentType | ||
| * @return A model response object. | ||
| */ | ||
| static ModelResponse<String> prepare(String jsonContent, String contentType) { |
There was a problem hiding this comment.
This method appears to be a generalisation of the method above it. I would rewrite (and rename) the method above this one to use the new method you wrote.
Added javadoc and refactored helper method to use a more general method.
|
I think it's best if we refactor the structure of the assertions in a separate pull request. I can open an issue. |
|
I've applied the other changes requested. |
|
Opened #66 for the assertion abstraction task. |
Added assertions on the response content type in
JsonSchemaAssertions.This fixes #59