Add config option record_history #917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanuele6
reviewed
Sep 6, 2020
| @@ -1812,6 +1813,7 @@ void get_setting(coordinates_t loc, char *name, FILE* rsp) | |||
| GET_BOOL(remove_disabled_monitors) | |||
| GET_BOOL(remove_unplugged_monitors) | |||
| GET_BOOL(merge_overlapping_monitors) | |||
| GET_BOOL(record_history) | |||
There was a problem hiding this comment.
You are using spaces for indentation here
Suggested change
| GET_BOOL(record_history) | |
| GET_BOOL(record_history) |
emanuele6
suggested changes
Sep 6, 2020
| @@ -992,7 +992,7 @@ Manage all the unmanaged windows remaining from a previous session\&. | |||
| .PP | |||
| \fB\-h\fR, \fB\-\-record\-history\fR on|off | |||
| .RS 4 | |||
| Enable or disable the recording of node focus history\&. | |||
There was a problem hiding this comment.
You should edit the asciidoc file, not the man page directly: this change will be overwritten when the man page is recompiled with make doc.
|
What's the point of this patch? But what is the point of having both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #909
This PR keeps the
bspc wm -h <true/false>command, which now changes therecord_historyconfig value.Additionally, you can call
bspc config record_history <true/false>to toggle history recording.