Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config option for ignore_history from bspc wm -h flag #909

Open
MyNameIsCosmo opened this issue Jan 25, 2019 · 1 comment · May be fixed by #917
Open

Config option for ignore_history from bspc wm -h flag #909

MyNameIsCosmo opened this issue Jan 25, 2019 · 1 comment · May be fixed by #917

Comments

@MyNameIsCosmo
Copy link
Contributor

I guess this is more of a style choice, but would it make sense to introduce a config option for ignore_history?
It seems like bspc config ignore_history true makes more sense than bspc wm -h false.

I could introduce a patch to have ignore_history handled by bspc config, and add a warning to deprecate bspc wm -h false, which would just point to the bspc config parameter.

Thoughts?
@baskerville
Copy link
Owner

Yes, you can make a pull request for this. Backward compatibility doesn't exist yet in this project: I'm using semantic versioning.

@MyNameIsCosmo MyNameIsCosmo linked a pull request Jan 30, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add config option record_history MyNameIsCosmo/bspwm
2 participants
@baskerville @MyNameIsCosmo