Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstallationsService::installPlugin() のユニットテスト #3928

Open
wants to merge 6 commits into
base: 5.1.x
Choose a base branch
from
+10 −3
Open

InstallationsService::installPlugin() のユニットテスト #3928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
252fd41
InstallationsService::installPlugin() のユニットテスト
dovanhung Oct 18, 2024
b38de99
ユニットテストを調整
TPGF00003 Oct 29, 2024
f370d12
Merge branch '5.1.x' into unittest_InstallationsService_installPlugin
TPGF00003 Oct 30, 2024
4d3b74d
CustomContentAppHelperTest::__construct() ユニットテスト
TPGF00003 Oct 30, 2024
c22e39e
CustomContentAppHelperTest::__construct() ユニットテスト
TPGF00003 Oct 30, 2024
126bece
Merge branch '5.1.x' into unittest_InstallationsService_installPlugin
ryuring Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion plugins/baser-core/tests/TestCase/Utility/BcComposerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,6 @@ public function testSelfUpdate()

$this->assertEquals(0, $rs['code']);
$this->assertEquals("A script named install would override a Composer command and has been skipped", $rs['out'][0]);
$this->assertMatchesRegularExpression("/(You are already using the latest available Composer version|Upgrading to version)/", $rs['out'][1]);
}

/**
Expand Down
3 changes: 2 additions & 1 deletion plugins/bc-installer/src/Service/InstallationsService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,13 +383,14 @@ public function installCorePlugin(): bool
* @return boolean
* @checked
* @noTodo
* @unitTest
*/
public function installPlugin($name)
{
BcUtil::clearAllCache();
/* @var BcPlugin $plugin */
$plugin = Plugin::isLoaded($name);
if(!$plugin) $plugin = Plugin::getCollection()->create($name);
if (!$plugin) $plugin = Plugin::getCollection()->create($name);
return $plugin->install();
}

Expand Down
9 changes: 8 additions & 1 deletion plugins/bc-installer/tests/TestCase/Service/InstallationsServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
use BcInstaller\Service\InstallationsServiceInterface;
use BcSearchIndex\Test\Scenario\Service\SearchIndexesServiceScenario;
use Cake\Core\Configure;
use Cake\Core\Exception\MissingPluginException;
use Cake\ORM\Exception\PersistenceFailedException;
use Cake\TestSuite\EmailTrait;
use CakephpFixtureFactories\Scenario\ScenarioAwareTrait;
Expand Down Expand Up @@ -331,7 +332,13 @@ public function testInstallCorePlugin()
*/
public function testInstallPlugin()
{
$this->markTestIncomplete('このテストは、まだ実装されていません。');
//プラグインがインストールしない場合、
$this->assertTrue($this->Installations->installPlugin('BcPluginSample'));

//存在しないプラグイン
$this->expectException(MissingPluginException::class);
$this->expectExceptionMessage('Plugin `BcPluginSampleTest` could not be found.');
$this->Installations->installPlugin('BcPluginSampleTest');
}

/**
Expand Down
Loading