Update status codes on proofs API for better monitoring #922
+59
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
ricardoMogg
changed the title
dneilroth
previously approved these changes
Aug 22, 2024
cb-heimdall
dismissed
dneilroth’s stale review
Approved review 2255982522 from dneilroth is now dismissed due to new commit. Re-request for approval.
dneilroth
approved these changes
Aug 23, 2024
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Update status codes for better monitoring * move the try/catch scope * error on missing trustedSignerAddress * update avatar upload status code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Updating to something more standardized.
409 means user has already claimed
500 means server or unexpected error
This will help us have better monitoring and alerts
Notes to reviewers
How has it been tested?
local testing directly to API calls