Fix incorrect linking to sepolia.basescan #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🟡 Heimdall Review Status
|
dneilroth
commented
Aug 22, 2024
| @@ -31,12 +29,13 @@ export default function SearchAddressInput({ onChange }: SearchAddressInputProps | |||
| /* 2. User enters an Basename */ | |||
| const validBasename = isBasename(value); | |||
|
|
|||
| const { basenameChain } = useBasenameChain(value as BaseName); | |||
There was a problem hiding this comment.
when value is an address or L1 ens and not a basename this always returns sepolia. value the address or name the user is trying to send to.
JFrankfurt
reviewed
Aug 22, 2024
Comment on lines
+32
to
+33
| const { chain: basenameChain } = useAccount(); | ||
| const resolverAddress = basenameChain?.id ? USERNAME_L2_RESOLVER_ADDRESSES[basenameChain.id] : '0x'; |
There was a problem hiding this comment.
if the user is connected to L1 then this won't be a basename chain, right? It'd just be any chain, and the resolver address will be 0x if not base/basesepolia?
if we're setting universalResolverAddress to 0x and the chainId to undefined or mainnet, what's the behavior here?
wbnns
added
base web review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
When a user is sending a name to a plain
0x..address or an L1 ens name, we incorrectly set thebaseNameChainas sepoliaThis PR makes it so that we always infer the chain from the connected account instead of from the ens name.
Notes to reviewers
How has it been tested?