Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show <0.001 instead of 0 when number gets small #912

Merged
merged 2 commits into from
Aug 22, 2024
Merged

fix: show <0.001 instead of 0 when number gets small #912

merged 2 commits into from
Aug 22, 2024

Conversation

JFrankfurt
Copy link
Contributor

@JFrankfurt JFrankfurt commented Aug 22, 2024 •
edited
Loading

image

@JFrankfurt JFrankfurt self-assigned this Aug 22, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 2:28am
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 2:28am

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 22, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

stevieraykatz
stevieraykatz previously approved these changes Aug 22, 2024
View reviewed changes
zencephalon
zencephalon reviewed Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@zencephalon zencephalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm should we increase the maximum number of fraction digits instead?

@cb-heimdall
Copy link
Collaborator

Review Error for zencephalon @ 2024-08-22 02:18:03 UTC
User failed mfa authentication, see go/mfa-help

omkarb
omkarb previously approved these changes Aug 22, 2024
View reviewed changes
@cb-heimdall cb-heimdall dismissed stale reviews from stevieraykatz and omkarb August 22, 2024 02:23

Approved review 2252895607 from stevieraykatz is now dismissed due to new commit. Re-request for approval.

@JFrankfurt
Copy link
Contributor Author

@zencephalon we could, but that would push the problem into the future and potentially create responsive layout issues on tiny screens

@JFrankfurt JFrankfurt merged commit b9bfc0b into master Aug 22, 2024
7 checks passed
@JFrankfurt JFrankfurt deleted the fix-premium-value-string branch August 22, 2024 02:36
kirkas pushed a commit that referenced this pull request Oct 21, 2024
@JFrankfurt
fix: show <0.001 instead of 0 when number gets small (#912)
ae59097 
* show <0.001 instead of 0 when number gets small

* extra check for timestamp ui removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevieraykatz stevieraykatz stevieraykatz approved these changes

@zencephalon zencephalon zencephalon approved these changes

@omkarb omkarb omkarb left review comments

@kirkas kirkas Awaiting requested review from kirkas

@brendan-defi brendan-defi Awaiting requested review from brendan-defi

Assignees

@JFrankfurt JFrankfurt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JFrankfurt @cb-heimdall @zencephalon @omkarb @stevieraykatz