Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basename Profile: Use route handler to generate OG/Twitter images #902

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

kirkas
Copy link
Collaborator

@kirkas kirkas commented Aug 21, 2024

This should generate all metadata needed for images:

image

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 21, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@kirkas kirkas requested a review from zencephalon August 21, 2024 13:34
Copy link

vercel bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 1:45pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 1:45pm

@zencephalon zencephalon merged commit f1bf4c5 into master Aug 21, 2024
7 checks passed
@zencephalon zencephalon deleted the basename-profile-og-image branch August 21, 2024 14:05
kirkas added a commit that referenced this pull request Oct 21, 2024
* use route handler to generate images

* prefetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants