Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Updated SigFigs on Premium Modal #899

Closed
wants to merge 1 commit into from

Conversation

brendan-defi
Copy link
Collaborator

What changed? Why?

  • Changed the way we determine the estimated total
    • was pulled directly from contract
    • now calculated from premium + normal one year cost
  • updated the number of significant digits

Notes to reviewers

How has it been tested?
locally

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 10:45pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 10:45pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 20, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants