Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/show landing page #894

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Fix/show landing page #894

merged 3 commits into from
Aug 20, 2024

Conversation

omkarb
Copy link
Collaborator

@omkarb omkarb commented Aug 20, 2024

What changed? Why?
remove landing page when not on the search screen + update faq style + edits.
Notes to reviewers

How has it been tested?

@omkarb omkarb requested review from kirkas and zencephalon August 20, 2024 21:16
Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 9:27pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 9:27pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Aug 20, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

zencephalon
zencephalon previously approved these changes Aug 20, 2024
ricardoMogg
ricardoMogg previously approved these changes Aug 20, 2024
@cb-heimdall cb-heimdall dismissed stale reviews from ricardoMogg and zencephalon August 20, 2024 21:21

Approved review 2249112240 from ricardoMogg is now dismissed due to new commit. Re-request for approval.

@omkarb omkarb merged commit 1a45f7b into master Aug 20, 2024
7 checks passed
@omkarb omkarb deleted the fix/show-landing-page branch August 20, 2024 21:31
kirkas pushed a commit that referenced this pull request Oct 21, 2024
* FAQ copy fixes

* remove landing page + update faqs

* Fix unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants