Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doc search): Refactor search box for optimal display on handheld devices #49

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix(doc search): Refactor search box for optimal display on handheld devices #49

merged 3 commits into from
Oct 5, 2023

Conversation

wbnns
Copy link
Member

@wbnns wbnns commented Oct 5, 2023

What changed? Why?

Fix search box that is overflowing into logo on handheld devices in docs

Notes to reviewers

Before

2023-10-05 at 11 46 33@2x

After

2023-10-05 at 11 48 10@2x

How has it been tested?

Localhost

@wbnns wbnns self-assigned this Oct 5, 2023
zencephalon
zencephalon reviewed Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@zencephalon zencephalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, can we try specifying just a max width and having this flex to fill the remaining space? I generally try to avoid fixed widths these days as a design element

@wbnns
Copy link
Member Author

wbnns commented Oct 5, 2023 •
edited
Loading

@zencephalon

Heya, thanks for taking a look -- sure thing: d19bb26

I know you mentioned max-width; I tested this locally and didn't see an issue using flex-grow instead. And we avoid use of defining a width altogether. PLMK what you think.

@wbnns wbnns requested a review from zencephalon October 5, 2023 15:44
@zencephalon zencephalon merged commit d9e7a9b into master Oct 5, 2023
1 check passed
@zencephalon zencephalon deleted the wbnns/search-mobile branch October 5, 2023 19:56
kirkas pushed a commit that referenced this pull request Oct 21, 2024
@wbnns
fix(doc search): Refactor search box for optimal display on handheld …
032e624 
…devices (#49)

* fix(docs search): rm keyboard shortcut from input

* fix(docs-search): decrease width of input

* fix(docs search): use flex-grow instead of width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zencephalon zencephalon zencephalon approved these changes

Assignees

@wbnns wbnns

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wbnns @zencephalon