Removed outdated line from base camp docs #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 20, 2024 09:59
|
Great catch! Thanks for the contribution! |
taycaldwell
approved these changes
Jan 21, 2024
zencephalon
approved these changes
Jan 22, 2024
|
@GNAR1ZARD Thanks for noticing this and fixing it! |
kirkas
pushed a commit
that referenced
this pull request
Oct 21, 2024
* updated baseCamp Docs * reverted master to origional clone * modified: apps/base-docs/base-camp/docs/deployment-to-testnet/deployment-to-base-sepolia-sbs.md --------- Co-authored-by: Gnarizard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
I omitted this line "The Coinbase Wallet has faucets built in. You can find them by clicking Settings -> Developer settings -> Testnet faucets." from the path: web/apps/base-docs/base-camp/docs/deployment-to-testnet/deployment-to-base-sepolia-sbs.md since the information no longer is valid.
Notes to reviewers
This is my first PR. I noticed this issue while reviewing the docs and then checked the issues tab in the repo. It seemed that it was fair game to submit a PR. Forgive me if I didnt anything out of convention, Im just trying to help :)
How has it been tested?
Its has nothing to do with any functional code and is just a slight adjustment to the docs.