Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 5_basename-frames.md #1499

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Update 5_basename-frames.md #1499

merged 1 commit into from
Dec 29, 2024

Conversation

Faerbol2
Copy link
Contributor

Fix typos

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 28, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel Vercel
Copy link

vercel bot commented Dec 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 4:13pm

@vercel Vercel
Copy link

vercel bot commented Dec 28, 2024

@Faerbol2 is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

wbnns
wbnns approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Faerbol2 Thank you

@wbnns wbnns enabled auto-merge (squash) December 29, 2024 13:10
@wbnns wbnns added the base docs review To be reviewed by the Base docs team label Dec 29, 2024
@wbnns wbnns merged commit ed4a8ce into base-org:master Dec 29, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
base docs review To be reviewed by the Base docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Faerbol2 @cb-heimdall @wbnns