Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix usage of <td> instead of <th> Update page.tsx #1483

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

famouswizard
Copy link

What changed? Why?

I noticed that in the table header, the <td> tag was being used to define column headers. This is not semantically correct, as the <th> tag should be used for table headers. Using <th> improves the structure of the HTML and makes the table more accessible, especially for screen readers and other assistive technologies.

I've updated the table header accordingly, replacing the <td> elements with the appropriate <th>.

Notes to reviewers

This change will help enhance both the semantics and accessibility of the table without affecting its appearance.

How has it been tested?

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 10:14am

Copy link

vercel bot commented Dec 26, 2024

@famouswizard is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@famouswizard
Copy link
Author

wbnns, please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants