Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revise ghostlogs to ghost with rebrand #1327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

revise ghostlogs to ghost with rebrand #1327

wants to merge 1 commit into from

Conversation

chrischang
Copy link
Contributor

What changed? Why?
Rebrand GhostLogs to Ghost

Notes to reviewers
Focus on the indexers (subgraphs) instead of gasless logs

How has it been tested?
Simple changes

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2024 5:20pm

@vercel Vercel
Copy link

vercel bot commented Dec 3, 2024

@chrischang is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 3, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 1/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

wbnns
wbnns requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrischang

Hello, could you please fix the merge conflict?

@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related community contribution labels Dec 18, 2024
@chrischang
Copy link
Contributor Author

@wbnns done ✅ :)

wbnns
wbnns approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrischang Ty!

@wbnns wbnns added question A question is awaiting an answer and removed change(s) requested One or more changes have been requested labels Dec 20, 2024
@wbnns wbnns removed the question A question is awaiting an answer label Dec 21, 2024
@wbnns
Copy link
Member

wbnns commented Dec 21, 2024

@chrischang Could you please rebase and sign your commits?

@wbnns wbnns added the change(s) requested One or more changes have been requested label Dec 21, 2024
@chrischang
Copy link
Contributor Author

@wbnns rebased on pushed!

@wbnns wbnns added ready for merge Ready for merge, an additional reviewer is needed and removed change(s) requested One or more changes have been requested labels Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
base ecosystem review This is ecosystem related ready for merge Ready for merge, an additional reviewer is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrischang @cb-heimdall @wbnns