Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lombard to ecosystem page #1326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pmurzin
Copy link

@pmurzin pmurzin commented Dec 3, 2024

What changed? Why?

Add Lombard to Base ecosystem partners

Notes to reviewers

Please let us know if there are any issues

How has it been tested?

Started web app locally to ensure it's working

Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 4:01pm

Copy link

vercel bot commented Dec 3, 2024

Someone is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@wbnns
Copy link
Member

wbnns commented Dec 20, 2024

@pmurzin

Hi there! Apologies, we recently updated the way we categorize and subcategorize apps; could you please rebase + update your PR, conforming to the new format by removing the tag, and defining the category and subcategory?

We'll do our best to review as soon as possible once you do! 🙏

@wbnns wbnns added change(s) requested One or more changes have been requested base ecosystem review This is ecosystem related labels Dec 20, 2024
@pmurzin
Copy link
Author

pmurzin commented Dec 20, 2024

@pmurzin

Hi there! Apologies, we recently updated the way we categorize and subcategorize apps; could you please rebase + update your PR, conforming to the new format by removing the tag, and defining the category and subcategory?

We'll do our best to review as soon as possible once you do! 🙏

thanks @wbnns. I've updated PR

@wbnns
Copy link
Member

wbnns commented Dec 28, 2024

@pmurzin

Thank you for the updates. Could you please:

  1. Rebase to resolve the merge conflict
  2. Share the contract address for LBTC
  3. Share the custody address where cbBTC is staked

...so that we can further proceed with the review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base ecosystem review This is ecosystem related change(s) requested One or more changes have been requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants