chore: add Telugu and Hindi translation of "Base is for everyone" on homepage #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Someone is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
|
Hello, thanks for contributing to Base! Could you please resolve the merge conflict? |
wbnns
added
change(s) requested
|
Hey @wbnns resolved the conflict, thanks |
wbnns
reviewed
Dec 19, 2024
| @@ -8,8 +8,7 @@ import { CSSProperties, useRef } from 'react'; | |||
| export default function SlidingTextSection() { | |||
| const containerRef = useRef<HTMLDivElement>(null); | |||
|
|
|||
| const text = ' Base is for everyone - بایس للجمیع - Base es para todos - 基地适合所有人 - La Base è per tutti - Base est pour tout le monde - Base ni ya kila mtu - Base yɛ ma obiara - Base nye amesiame tɔ - Base ji he ni mɔ fɛɛ mɔ yɔɔ - '; | |||
|
|
|||
| const text = ' Base is for everyone - بایس للجمیع - Base es para todos - 基地适合所有人 - La Base è per tutti - Base est pour tout le monde - Base ni ya kila mtu - Base yɛ ma obiara - Base nye amesiame tɔ - Base ji he ni mɔ fɛɛ mɔ yɔɔ - బేస్ అందరి కోసం - बेस सबके लिए है -'; | |||
There was a problem hiding this comment.
There should be a space at the end of the line after - and before '
|
@Deveshb15 Thank you for the updates; requested and additional change in-line 🙏 |
wbnns
added
base web review
|
Hey @wbnns made all the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Adding Telugu and Hindi to our "Base is for everyone" slider.
To replicate this PR:
Clone the repo and follow steps in Getting Started
Open apps/web/src/components/base-org/root/SlidingTextSection/index.tsx
Modify text by adding your language to the end of the line, followed by " - "
Notes to reviewers
How has it been tested?
Run yarn workspace @app/web dev
Navigate to http://localhost:3000 in your browser
Make sure the slider is working as expected