Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Docs Request: Base Learn - Need to fix the link in the Deploymen… #1200

Closed

Conversation

gabrieltemtsen
Copy link

…t Exercise docs #1192

What changed? Why?
Edited the link of the hyper link to target the right folder
Notes to reviewers

How has it been tested?
by clicking the hyper link it reaches it's target

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ❌ Failed (Inspect) Nov 4, 2024 4:47pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 4, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/2
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Copy link

vercel bot commented Nov 4, 2024

@gabrieltemtsen is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@wbnns
Copy link
Member

wbnns commented Nov 8, 2024

@gabrieltemtsen

Hi there! Thanks for this PR! There is currently no issue with the link, here:
https://docs.base.org/base-learn/docs/deployment-to-testnet/deployment-to-testnet-exercise

Let's leave as is 🙏

@wbnns wbnns closed this Nov 8, 2024
@gabrieltemtsen
Copy link
Author

@gabrieltemtsen

Hi there! Thanks for this PR! There is currently no issue with the link, here: https://docs.base.org/base-learn/docs/deployment-to-testnet/deployment-to-testnet-exercise

Let's leave as is 🙏
The issue is in the hyper-link when [ Basic Math ] is clicked

Screen.Recording.2024-11-08.at.10.30.42.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants