Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add addresses for Fault Proof contracts on Mainnet L1 #1168

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Add addresses for Fault Proof contracts on Mainnet L1 #1168

merged 2 commits into from
Oct 29, 2024

Conversation

cbfyi
Copy link
Contributor

@cbfyi cbfyi commented Oct 28, 2024 •
edited
Loading

What changed? Why?

Similar to #656, but for mainnet.

Notes to reviewers

Addresses can be verified using https://github.com/ethereum-optimism/superchain-ops/pull/352/files#diff-0aee6ef7ca0ce5497080deb4551d5f285d7747b8aabd63c250d5b356fd2f8225

Or alternatively, calling 0x43edB88C4B80fDD2AdFF2412A7BebF9dF42cB40e (see this PR for details).

How has it been tested?

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 9:11pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 28, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024

@cbfyi is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cbfyi cbfyi requested a review from awilliams1-cb October 28, 2024 21:07
@cb-heimdall
Copy link
Collaborator

Review Error for awilliams1-cb @ 2024-10-28 22:04:40 UTC
User must have write permissions to review

henridevieux
henridevieux approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@henridevieux henridevieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses are accurate as compared with my local notes from terraform output of contract creation

@wbnns wbnns merged commit 872d2b3 into base-org:master Oct 29, 2024
5 of 6 checks passed
@cbfyi cbfyi deleted the fp-mainnet branch October 29, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awilliams1-cb awilliams1-cb awilliams1-cb approved these changes

@henridevieux henridevieux henridevieux approved these changes

@wbnns wbnns wbnns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cbfyi @cb-heimdall @wbnns @henridevieux @awilliams1-cb