Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require response content-type be an image #1052

Merged
merged 1 commit into from
Oct 9, 2024
Merged

require response content-type be an image #1052

merged 1 commit into from
Oct 9, 2024

Conversation

JFrankfurt
Copy link
Contributor

@JFrankfurt JFrankfurt commented Oct 9, 2024 •
edited
Loading

enforces only image content, and disallows svg

image

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 5:49pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 5:49pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Oct 9, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@JFrankfurt JFrankfurt requested review from omkarb and a team October 9, 2024 17:46
@JFrankfurt JFrankfurt self-assigned this Oct 9, 2024
@JFrankfurt JFrankfurt enabled auto-merge (squash) October 9, 2024 17:48
@JFrankfurt JFrankfurt merged commit 0b42cce into master Oct 9, 2024
8 checks passed
@JFrankfurt JFrankfurt deleted the restrict-proxy-content-type branch October 9, 2024 17:52
kirkas pushed a commit that referenced this pull request Oct 21, 2024
@JFrankfurt
require response content-type be an image (#1052)
9ca7d77
kirkas pushed a commit that referenced this pull request Oct 21, 2024
@JFrankfurt
require response content-type be an image (#1052)
aa3a2fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkarb omkarb omkarb approved these changes

Assignees

@JFrankfurt JFrankfurt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JFrankfurt @cb-heimdall @omkarb