Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a heatmap #1022

Merged
merged 9 commits into from
Oct 2, 2024
Merged

feat: add a heatmap #1022

merged 9 commits into from
Oct 2, 2024

Conversation

JFrankfurt
Copy link
Contributor

@JFrankfurt JFrankfurt commented Sep 27, 2024

desktop mobile
image image

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:15pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 7:15pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 27, 2024

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

apps/web/pages/api/proxy/index.ts Dismissed Show dismissed Hide dismissed
@JFrankfurt JFrankfurt requested review from a team and ricardoMogg October 1, 2024 20:42
@JFrankfurt JFrankfurt self-assigned this Oct 1, 2024
@JFrankfurt JFrankfurt marked this pull request as ready for review October 1, 2024 20:43
@0xchiaroscuro
Copy link

color for gray squares should be #F8F9FB.

Also can we apply less spacing between the 2 rows of data? looks really spacious rn. Attaching designs

Screenshot 2024-10-01 at 4 48 49 PM Screenshot 2024-10-01 at 4 48 58 PM

@0xchiaroscuro
Copy link

Uploading Screenshot 2024-10-01 at 6.15.27 PM.png…

attaching color scale

ETHERSCAN_API_KEY=
BASESCAN_API_KEY=
TALENT_PROTOCOL_API_KEY=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these keys need to be added to config service or are they already in there?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these still need to be added via codeflow 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes proposed

@0xchiaroscuro
Copy link

Screenshot 2024-10-01 at 6 15 27 PM (1)

@cb-heimdall
Copy link
Collaborator

Review Error for 0xchiaroscuro @ 2024-10-02 19:07:04 UTC
User must have write permissions to review

@cb-heimdall
Copy link
Collaborator

This Pull Request was merged without enough reviews
Please go here to review and +1

JFrankfurt added a commit that referenced this pull request Oct 2, 2024
JFrankfurt added a commit that referenced this pull request Oct 2, 2024
@JFrankfurt JFrankfurt restored the heatmap branch October 2, 2024 23:58
JFrankfurt added a commit that referenced this pull request Oct 2, 2024
JFrankfurt added a commit that referenced this pull request Oct 3, 2024
@cb-heimdall
Copy link
Collaborator

This Pull Request was merged without enough reviews
Please go here to review and +1

kirkas pushed a commit that referenced this pull request Oct 21, 2024
* add a heatmap

* styling and public env vars

* heatmap polish

* add support for sepolia deployments, add styling input

* update icon

* responsive heatmap

* improve url security

* heatmap-color-update (#1030)
kirkas pushed a commit that referenced this pull request Oct 21, 2024
kirkas pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants