fix card / cover rendering bug (#1400)

base-org · Dec 16, 2024 · c6fe6c8 · c6fe6c8
1 parent d5c5161
commit c6fe6c8
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 24 deletions.
diff --git a/apps/web/app/(basenames)/name/[username]/opengraph-image.tsx b/apps/web/app/(basenames)/name/[username]/opengraph-image.tsx
@@ -80,20 +80,20 @@ export default async function OpenGraphImage(props: ImageRouteProps) {
       universalResolverAddress: USERNAME_L2_RESOLVER_ADDRESSES[chain.id],
     });
 
-    if (!avatar) return;
-
-    // IPFS Resolution
-    if (IsValidIpfsUrl(avatar)) {
-      const ipfsUrl = getIpfsGatewayUrl(avatar as IpfsUrl);
-      if (ipfsUrl) {
-        imageSource = ipfsUrl;
+    if (avatar) {
+      // IPFS Resolution
+      if (IsValidIpfsUrl(avatar)) {
+        const ipfsUrl = getIpfsGatewayUrl(avatar as IpfsUrl);
+        if (ipfsUrl) {
+          imageSource = ipfsUrl;
+        }
+      } else {
+        imageSource = avatar;
       }
-    } else {
-      imageSource = avatar;
-    }
 
-    // Cloudinary resize / fetch
-    imageSource = getCloudinaryMediaUrl({ media: imageSource, format: 'png', width: 80 });
+      // Cloudinary resize / fetch
+      imageSource = getCloudinaryMediaUrl({ media: imageSource, format: 'png', width: 80 });
+    }
   } catch (error) {
     logger.error('Error fetching basename Avatar:', error);
   }

diff --git a/apps/web/pages/api/basenames/[name]/assets/cardImage.svg.tsx b/apps/web/pages/api/basenames/[name]/assets/cardImage.svg.tsx
@@ -55,20 +55,20 @@ export default async function handler(request: NextRequest) {
       universalResolverAddress: USERNAME_L2_RESOLVER_ADDRESSES[chain.id],
     });
 
-    if (!avatar) return;
-
-    // IPFS Resolution
-    if (IsValidIpfsUrl(avatar)) {
-      const ipfsUrl = getIpfsGatewayUrl(avatar as IpfsUrl);
-      if (ipfsUrl) {
-        imageSource = ipfsUrl;
+    if (avatar) {
+      // IPFS Resolution
+      if (avatar && IsValidIpfsUrl(avatar)) {
+        const ipfsUrl = getIpfsGatewayUrl(avatar as IpfsUrl);
+        if (ipfsUrl) {
+          imageSource = ipfsUrl;
+        }
+      } else if (avatar) {
+        imageSource = avatar;
       }
-    } else {
-      imageSource = avatar;
-    }
 
-    // Cloudinary resize / fetch
-    imageSource = getCloudinaryMediaUrl({ media: imageSource, format: 'png', width: 120 });
+      // Cloudinary resize / fetch
+      imageSource = getCloudinaryMediaUrl({ media: imageSource, format: 'png', width: 120 });
+    }
   } catch (error) {
     logger.error('Error fetching basename Avatar:', error);
   }