core, eth, node, rpc: port the admin and debug API #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bas-vk
force-pushed
the
rcp-v2-rebase
branch
2 times, most recently
from
32fefdb to
4b28705
Compare
bas-vk
force-pushed
the
rcp-v2-rebase
branch
3 times, most recently
from
d1e2312 to
eae8146
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the base admin commands:
and also all of the debug commands. The remaining admin commands are either natspec, registrar, or the http/sleep methods are a bit questionable, so we should discuss those.
Additionally, I tried to verify all the commands so that they work, the only one I've implemented but is commented out is the StartRPC, because it introduces a circular dependency. We'd need to upgrade the HttpRpc too to use the new decoupled implementation before that code can be included in the
nodepackage.