dialog: REVERT fix rtags of forking INVITE with 100rel (#947) #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreimers
changed the title
|
CC: @maximilianfridrich |
|
I don't think we need to hurry here and I would prefer a clean fix. Currently, PRs for the next version are already merged to main, so it will take a few more steps to release a v3.6.1 from a extra branch. This is nothing we should do on a weekend. |
|
Sebastian Reimers writes:
I don't think we need to hurry here and I would prefer a clean
fix. Currently, PRs for the next version are already merged to main,
so it will take a few more steps to release a v3.6.1 from a extra
branch. This is nothing we should do on a weekend.
My Android app is using main branch of re. So now the app in F-Droid is
broken. I don't see any need to wait for a clean fix. That can come
with a new PR. The issue the PR was fixing was a corner case (100rel
with forked INVITE), whereas the PR broke a very common use case.
|
|
It makes no sense at all to release v3.6.1 when it is known that it contains a major bug. But as I wrote, I don't need v3.6.1, I need main where the bug has been fixed. |
cspiel1
added a commit
to cspiel1/re
that referenced
this pull request
Oct 23, 2023
…usage (hold/unhold) (baresip#986)" This reverts commit 6471c63.
sreimers
pushed a commit
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which broke common re-invite usage (hold/unhold). See baresip/baresip#2772. I'll wait a couple of hours and if no other fix is provided, I'll merge this PR. The most common re-invite use case must work.