test/http: decrease test runs from 20 to 3 to decrease test time #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fAuernigg
force-pushed
the
speedup_https_tests
branch
2 times, most recently
from
4b714b0 to
3df9104
Compare
|
Multiple HTTP requests are sent in parallel. Processing of the responses are done asynchronously in the main thread. The test should ensure that there is no double free, memleak, mix-up of content, ... for multiple parallel requests. |
fAuernigg
force-pushed
the
speedup_https_tests
branch
from
3df9104 to
5fadeb4
Compare
alfredh
reviewed
Nov 21, 2024
test/http.c
Outdated
| err = http_client_alloc(&cli, dnsc); | ||
| if (err) | ||
| goto out; | ||
|
|
||
| err = http_client_set_config(cli, &hconf); | ||
| if (err) | ||
| goto out; |
There was a problem hiding this comment.
please check indentation ..
|
Thanks, this looks much better .. do you have any numbers for benchmarking on Linux ...? |
Multiple HTTP requests are sent in parallel. Processing of the responses are done asynchronously in the main thread. The test should ensure that there is no double free, memleak, mix-up of content, ... for multiple parallel requests. Fixes baresip#1211 slow https test.
fAuernigg
force-pushed
the
speedup_https_tests
branch
from
5fadeb4 to
70ff497
Compare
test_https_conn_post_handshake takes ~280ms instead ~1850ms on linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves performance of test/http: #1211