Add option to specify mount point #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @NicoHood , thanks for being a contributor. Feel free to help as little or as much as you are able. No obligation or expectations. I did assign you as a reviewer on this PR. I may ask you to review some other PR's upcoming if you have the time. It would be good to have someone else reviewing the changes other than myself. Again, no expectations here, and if you feel like you want to help review PR's and it becomes more than you are interested in doing, also let me know. |
NicoHood
reviewed
Feb 10, 2021
| else | ||
| for x in $UUIDS; do | ||
| UUIDS_ARRAY[$i]=$x | ||
| if [[ "$x" == "$uuid_cmdline" && ${SUBVOLIDS_ARRAY[$((i))]} == "$subvolid_cmdline" && ${TARGETS_ARRAY[$((i))]} == "$mount_cmdline" ]]; then |
There was a problem hiding this comment.
I would do something like:
if [[ -n "$mount_cmdline" && ${TARGETS_ARRAY[$((i))]} != "$mount_cmdline" ]]; then
continue
fi
This should make the code smaller, but I did not test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to specify mount point. Fixes #71