Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tss] support query signature #6

Draft
wants to merge 43 commits into
base: main
Choose a base branch
from
Draft

[tss] support query signature #6

wants to merge 43 commits into from

Conversation

nkitlabs
Copy link
Contributor

Open PR for review only, not merge into master yet.

Implementation details

  • support query signature
  • fix example

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the GitHub PR explorer)

@nkitlabs nkitlabs added the not merge This PR needs review but not ready to be merged label May 16, 2024
warittornc
warittornc reviewed May 17, 2024
View reviewed changes
Copy link
Member

@warittornc warittornc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix tests and lint as well

client/helper.go Outdated Show resolved Hide resolved
client/rpc.go Outdated Show resolved Hide resolved
client/rpc.go Outdated Show resolved Hide resolved
client/types.go Outdated Show resolved Hide resolved
client/types.go Outdated Show resolved Hide resolved
warittornc
warittornc reviewed May 17, 2024
View reviewed changes
client/rpc.go Outdated Show resolved Hide resolved
@nkitlabs nkitlabs requested a review from warittornc May 28, 2024 06:42
@RogerKSI RogerKSI requested a review from taobun May 28, 2024 06:45
RogerKSI
RogerKSI requested changes May 28, 2024
View reviewed changes
client/rpc.go Outdated Show resolved Hide resolved
@nkitlabs nkitlabs requested a review from RogerKSI May 28, 2024 09:26
@RogerKSI
Copy link
Collaborator

Note: Need to update import module before merging

@RogerKSI RogerKSI self-requested a review June 23, 2024 06:20
@RogerKSI RogerKSI marked this pull request as draft June 23, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satawatnack satawatnack Awaiting requested review from satawatnack

@warittornc warittornc Awaiting requested review from warittornc

@taobun taobun Awaiting requested review from taobun

@RogerKSI RogerKSI Awaiting requested review from RogerKSI

Assignees
No one assigned
Labels
not merge This PR needs review but not ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkitlabs @RogerKSI @warittornc