[tunnel] Check Route readiness #535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taobun
approved these changes
Dec 20, 2024
RogerKSI
requested changes
Dec 23, 2024
Comment on lines
+294
to
+302
| case *types.IBCRoute: | ||
| portID := PortIDForTunnel(tunnelID) | ||
|
|
||
| // retrieve the dynamic capability for this channel | ||
| _, found := k.scopedKeeper.GetCapability( | ||
| ctx, | ||
| host.ChannelCapabilityPath(portID, route.ChannelID), | ||
| ) | ||
| return found |
There was a problem hiding this comment.
do we need to check if it's open channel as well? or it's already done that?
There was a problem hiding this comment.
if yes, need to update on MsgUpdateRoute as well?
Comment on lines
+207
to
+216
| route, err := tunnel.GetRouteValue() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // check whether the router is ready or not | ||
| if !k.IsRouteReady(ctx, route, tunnelID) { | ||
| return types.ErrRouteNotReady.Wrapf("tunnelID: %d", tunnelID) | ||
| } | ||
|
|
There was a problem hiding this comment.
move this to above of set active tunnel ID,, prevent state changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)