Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][tunnel] use default timestamp from blocktime instead of 0, cleanup test #510

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

RogerKSI
Copy link
Contributor

@RogerKSI RogerKSI commented Dec 2, 2024

Fixed:

  • cleanup test case to use real format of signal id
  • use the timestamp from block time for not_in_current_feeds in the tunnel instead of 0 (GenerateNewPrices function x/tunnel/keeper/helper.go)

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI requested review from nkitlabs, colmazia, taobun and satawatnack and removed request for nkitlabs and colmazia December 2, 2024 20:18
@RogerKSI RogerKSI merged commit 774ab71 into master Dec 3, 2024
2 checks passed
@RogerKSI RogerKSI deleted the timestamp-tunnel branch December 3, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants