Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Feeds] Fix Grogu #486

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[Fix][Feeds] Fix Grogu #486

merged 1 commit into from
Nov 26, 2024

Conversation

colmazia
Copy link
Contributor

@colmazia colmazia commented Nov 25, 2024

Implementation details

  • tracking for change in price status in shouldUpdatePrice function
  • handle divide by zero case in deviation check
  • update unit tests

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI merged commit 7eefc18 into master Nov 26, 2024
2 checks passed
@RogerKSI RogerKSI deleted the fix-grogu branch November 26, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants